mon: fix off-by-one rendering progress bar

[liewegas]

Ensure that if progress is < 1.0, we always have a '.' at the end of the
bar.

Signed-off-by: Sage Weil sage@redhat.com

[liewegas]

Problem with old code is I have

    "progress_events": {
        "b93f002c-9d75-4d56-bc8e-a947f0d36e8a": {
            "message": "Rebalancing after osd.123 marked out",
            "progress": 0.97894233465194702
        }
    }
}

and from ceph -s

  progress:
    Rebalancing after osd.123 marked out
      [==============================]

[sebastian-philipp]

jenkins retest this please

[tchaikov]

162/175 Test #165: unittest_rgw_dmclock_scheduler ..........***Failed    0.42 sec
...
[ RUN      ] Queue.AsyncRequest
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_rgw_dmclock_scheduler.cc:168: Failure
Value of: context.stopped()
  Actual: false
Expected: true
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_rgw_dmclock_scheduler.cc:170: Failure
Value of: ec1
  Actual: false
Expected: true
[  FAILED  ] Queue.AsyncRequest (0 ms)
[ RUN      ] Queue.Cancel
[       OK ] Queue.Cancel (1 ms)
[ RUN      ] Queue.CancelClient
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_rgw_dmclock_scheduler.cc:270: Failure
Value of: context.stopped()
  Actual: false
Expected: true
did not load config file, using default settings.
2019-05-29 13:18:58.992 7f60e608b6c0 -1 Errors while parsing config file!
2019-05-29 13:18:58.992 7f60e608b6c0 -1 parse_file: cannot open /etc/ceph/ceph.conf: (2) No such file or directory
2019-05-29 13:18:58.992 7f60e608b6c0 -1 parse_file: cannot open /home/jenkins-build/.ceph/ceph.conf: (2) No such file or directory
2019-05-29 13:18:58.992 7f60e608b6c0 -1 parse_file: cannot open ceph.conf: (2) No such file or directory
2019-05-29 13:18:58.992 7f60e608b6c0 -1 Errors while parsing config file!
2019-05-29 13:18:58.992 7f60e608b6c0 -1 parse_file: cannot open /etc/ceph/ceph.conf: (2) No such file or directory
2019-05-29 13:18:58.992 7f60e608b6c0 -1 parse_file: cannot open /home/jenkins-build/.ceph/ceph.conf: (2) No such file or directory
2019-05-29 13:18:58.992 7f60e608b6c0 -1 parse_file: cannot open ceph.conf: (2) No such file or directory
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_rgw_dmclock_scheduler.cc:275: Failure
Value of: ec2
  Actual: false
Expected: true
[  FAILED  ] Queue.CancelClient (0 ms)
[ RUN      ] Queue.CancelOnDestructor
[       OK ] Queue.CancelOnDestructor (1 ms)
[ RUN      ] Queue.CrossExecutorRequest
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_rgw_dmclock_scheduler.cc:381: Failure
Value of: queue_context.stopped()
  Actual: false
Expected: true
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_rgw_dmclock_scheduler.cc:387: Failure
Value of: callback_context.stopped()
  Actual: false
Expected: true
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_rgw_dmclock_scheduler.cc:389: Failure
Value of: ec1
  Actual: false
Expected: true
[  FAILED  ] Queue.CrossExecutorRequest (0 ms)
[ RUN      ] Queue.SpawnAsyncRequest
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/rgw/test_rgw_dmclock_scheduler.cc:426: Failure
Value of: context.stopped()
  Actual: false
Expected: true
[  FAILED  ] Queue.SpawnAsyncRequest (1 ms)
[----------] 8 tests from Queue (5 ms total)

[----------] Global test environment tear-down
[==========] 8 tests from 1 test suite ran. (5 ms total)
[  PASSED  ] 4 tests.
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] Queue.AsyncRequest
[  FAILED  ] Queue.CancelClient
[  FAILED  ] Queue.CrossExecutorRequest
[  FAILED  ] Queue.SpawnAsyncRequest

tracked by http://tracker.ceph.com/issues/40069

[tchaikov]

retest this please

[tchaikov]

• http://pulpito.ceph.com/kchai-2019-06-02_15:00:54-rados-wip-kefu-testing-2019-06-01-2346-distro-basic-mira/
• http://pulpito.ceph.com/nojha-2019-06-04_22:13:54-rados-wip-kefu-testing-2019-06-01-2346-distro-basic-smithi/

the valgrind failure is a known issue tracked by http://tracker.ceph.com/issues/38403, and it should be addressed by #28397

[tchaikov]

@liewegas @jecluis backported to nautilus at #28398