nautilus: mgr: Update the restful module in nautilus #28291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently do not expose perf counters in the restful module but this is a useful piece of information to be exposed by the restful module. Since we already have a function to gather all the information about the perf counters, we can make this easily accessible through the restful API. This also supports filtering by daemons through regexps. Signed-off-by: Boris Ranto <branto@redhat.com> (cherry picked from commit aaaef91)
for better readability Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit aadb8ec)
unlike python2, python3 returns an iterator instead of a list, so construct a list using list comprehension directly. Fixes: https://tracker.ceph.com/issues/38628 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 427bca8)
tchaikov
approved these changes
May 29, 2019
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/39695
possibly a backport of #27925
parent tracker: https://tracker.ceph.com/issues/38628
original PR body:
This updates the restful module to what we have in master. It contains the patch to expose perf counters through the restful module and a couple of fixes for python3.
updated using ceph-backport.sh version 15.1.1.389