mon: fix min_last_epoch_started tracking #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were only invalidating the cache from the legacy apply_incremental(), which is no longer called on modern clusters. Fixes: #9987 Signed-off-by: Sage Weil <sage@redhat.com>
We were only invalidating the cached value from apply_incremental, which is no longer called on modern clusters. Fix this by storing the update epoch in the key as well (it is not part of osd_stat_t). Backport: giant, firefly, dumpling(?) Fixes: #9987 Signed-off-by: Sage Weil <sage@redhat.com>
|
I think this is correct. I'm in the process of testing. |
ghost
added
the
|
wip-sam-testing |
|
All testing I performed showed no signs of misbehaving. I wasn't however able to reproduce a state in which this would have been helpful against leveldb growth but it is logically correct and have no evidence it will cause harm -- on the contrary, it should keep things saner. I'm okay with merging. |
|
went through a suite, all green. |
athanatos
pushed a commit
that referenced
this pull request
Nov 10, 2014
mon: fix min_last_epoch_started tracking Reviewed-by: Joao Eduardo Luis <joao@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been broken for a long time! I think it's why we've seen some reports
of leveldb growth?