crimson/osd: add --mkkey support #28534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
commented
Jun 13, 2019
src/common/buffer.cc
Outdated
| @@ -1838,6 +1844,33 @@ ssize_t buffer::list::read_fd(int fd, size_t len) | |||
| return ret; | |||
| } | |||
|
|
|||
| #ifdef WITH_SEASTAR | |||
There was a problem hiding this comment.
i can move this helper into src/crimson/common so we don't need to taint buffer.h and buffer.cc in this way.
There was a problem hiding this comment.
We might also consider src/common/buffer_seastar.cc.
tchaikov
commented
Jun 13, 2019
rzarzynski
approved these changes
Jun 13, 2019
| derr << "Unable to get a Ceph keyring." << dendl; | ||
| forker.exit(1); | ||
| } | ||
| KeyRing keyring; |
src/common/buffer.cc
Outdated
| @@ -1838,6 +1844,33 @@ ssize_t buffer::list::read_fd(int fd, size_t len) | |||
| return ret; | |||
| } | |||
|
|
|||
| #ifdef WITH_SEASTAR | |||
There was a problem hiding this comment.
We might also consider src/common/buffer_seastar.cc.
|
i will move the read/write file helpers for crimson to |
tchaikov
force-pushed
the
wip-crimson-mkkey
branch
from
933404b
to
9f58998
Compare
it never fails unless out of memory. and it would be simpler to just allocate it on stack. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-crimson-mkkey
branch
from
9f58998
to
b9fe760
Compare
rzarzynski
reviewed
Jun 14, 2019
Signed-off-by: Kefu Chai <kchai@redhat.com>
instead of using the blocking calls so we can write to file without blocking the reactor Signed-off-by: Kefu Chai <kchai@redhat.com>
see qa/tasks/ceph.py for how it is used, and why we need it. Signed-off-by: Kefu Chai <kchai@redhat.com>
OSD::stop() is a top-level method in the sense that it will be called directly when engine stops. so it should not throw any exceptions. instead, we will print out the error and ignore the exception if any. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-crimson-mkkey
branch
from
b9fe760
to
5461047
Compare
|
@rzarzynski fixed and repushed. |
tchaikov
added this to Done
in crimson (moved to https://trello.com/b/lbHkWKxh/crimson)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.