KeyValueStore: move buffers from strip_header to BufferTransaction #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -249,6 +249,8 @@ class KeyValueStore : public ObjectStore, | |||
|
|
|||
| //Dirty records | |||
| StripHeaderMap strip_headers; | |||
| map<pair<string, string>, bufferlist> buffers; // pair(prefix, key),to buffer updated data in one transaction | |||
There was a problem hiding this comment.
map<pair<string, string> bufferlist> isn't enough to locate the unique bufferlist. Multi object may exists in the same BufferTransaction, so we need ghobject_t key to unique it
There was a problem hiding this comment.
The codes is under a seq write 64k test to write 200GB data from rbd volume, and a rand write 4k test for 700secs without any osd crash
Please help to review, thx
xuechendi
force-pushed
the
move_buffers_to_BufferTransaction
branch
from
9f1dba2
to
341eb47
Compare
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
xuechendi
force-pushed
the
move_buffers_to_BufferTransaction
branch
from
341eb47
to
54ee8ee
Compare
|
It seemed good to me! |
liewegas
added a commit
that referenced
this pull request
Nov 11, 2014
…tion KeyValueStore: move buffers from strip_header to BufferTransaction Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is related to the patch #2875
This patch is another way to get rid of the 'osd crash' problem during KeyValueStore test
'strip_header' in KeyValueStore is used to cache all updated headers, 'buffers' is used to ensure all io in one transaction use buffers to access the lastest update.
Move buffers from strip_header to BufferTransaction can ensure 'buffers' being destructed after the transaction being submitted, which prevent growing 'strip_header->buffers' causing OOM problem.
Also, for all 'meta collection' will be cached in strip_header, and there lacks of lock of parallel io accessing meta collection, multi-thread accesing the 'meta collection' strip_header->buffers causes segmentation fault, when moving 'buffers' from strip_header to BufferTransaction can prevent such scenario.
Signed-off-by: Chendi.Xue chendi.xue@intel.com