pybind/rados: fix set_omap() crash on py3 #29096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason vals was ending up NULL inside rados_write_op_omap_set Signed-off-by: Sage Weil <sage@redhat.com>
Just paranoia about the lifecycle here Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-pybind-rados-set-omap
branch
from
c047b26
to
86ef15f
Compare
|
retest this please |
jdurgin
approved these changes
Jul 19, 2019
|
jenins, retest this please |
liewegas
added a commit
that referenced
this pull request
Jul 22, 2019
* refs/pull/29096/head: pybind/rados: put lens array in outer scope pybind/rados: fix set_omap() crash on py3 Reviewed-by: Josh Durgin <jdurgin@redhat.com>
|
According to #30483 (comment) this might need a backport to Nautilus? |
|
parent tracker (i.e. the bug fixed by this PR): https://tracker.ceph.com/issues/42082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/42082