cmake: require CMake v3.10.2 #29291
cmake: require CMake v3.10.2 #29291
Conversation
|
from jenkins,
|
|
@alfredodeza @djgalloway can we label the jenkins slave so that only bionic and centos7 slaves are used for testing master? currently, we choose "huge && (centos7 || trusty) && rebootable" for testing PRs. see |
We don't actually have any Bionic slaves. Any Ubuntu packages are built on a Xenial slave using pbuilder. See https://github.com/ceph/mita/blob/master/deploy/playbooks/roles/common/templates/prod_nodes.py.j2#L81-L92 Notice a |
|
what we need is to re-do the labelling and cleanup, because the current way doesn't help and it was the compromise to keep things running when things migrated from the very first jenkins iteration. Having a label that says 'bionic' when it really isn't is super confusing :( |
|
@djgalloway @alfredodeza is it possible for us to use 'Ubuntu 18.04' for 'trusty_huge' ? or better off defining a new type of node 'bionic'? and then, we could, as @alfredodeza suggested, re-label the slaves and clean up the templates a little bit? |
to enable us to build on xenial, install newer cmake. cmake 3.10.2 is the version offered by bionic. with this change, we can safely require cmake 3.10.2 in our cmake script. as EPEL7 offers cmake 3.13 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-cmake-cleanups
branch
from
494a768
to
80c703b
Compare
|
retest this please. |
tchaikov
force-pushed
the
wip-cmake-cleanups
branch
from
80c703b
to
92f027a
Compare
|
changelog
@cbodley could you take another look? |
| set(CMAKE_C_EXTENSIONS ON) | ||
| set(C_STANDARD_REQUIRED ON) | ||
| endif() | ||
| set(CMAKE_CXX_STANDARD 17) |
There was a problem hiding this comment.
this helps fmt to use C++17 instead of falling back to C++11. which fails the build.
|
It is going to take a good chunk of effort to have true Bionic nodes, starting with Python 3 support which none of our tooling is ready for |
since we dropped the support of xenial, we now have the luxury of using newer CMake! and by using CMake 3.10.2, we can prevent libfmt from assuming that we are using C++11, and hence set `CMAKE_CXX_STANDARD` to 11, which will literally append `-std=gnu++11` to `CMAKE_CXX_FLAGS`. the last `-std` option passed to `g++` takes precendence. since we've switched over to C++17, and we are using C++17 features. so, using cmake older than 3.8 breaks the build. because it is CMake 3.8 which stared support `CMAKE_CXX_STANDARD` 17. - for bionic: https://packages.ubuntu.com/bionic/cmake : 3.10.2 - for CentOS7: https://dl.fedoraproject.org/pub/epel/7/x86_64/Packages/c/ : 3.13.5 so in this change, * bump up the required version to v3.10.2 * cleanups to wipe out the workaround for lower CMake versions * use `PROJECT_VERSION` defined by `project()` command instead of `VERSION` explicitly defined. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-cmake-cleanups
branch
from
92f027a
to
bbb69fe
Compare
since we dropped the support of xenial, we now have the luxury of using
newer CMake!
https://dl.fedoraproject.org/pub/epel/7/x86_64/Packages/c/ : 3.13.5
so in this change,
Signed-off-by: Kefu Chai kchai@redhat.com