common,tools,crush,test: misc converity & klocwork fixes #29316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Songweibin
commented
Jul 25, 2019
Songweibin
commented
- References tracker ticket
- Updates documentation if necessary
- Includes tests for new functionality or reproducer for bug
fix klocwork issues: function 'strcpy' does not check buffer boundaries but outputs to buffer 'watcher.addr' of fixed size (256） Signed-off-by: songweibin <song.weibin@zte.com.cn>
neha-ojha
approved these changes
Jul 25, 2019
tchaikov
reviewed
Jul 26, 2019
CID 174874 (ceph#2 of 2): Dereference after null check (FORWARD_NULL) 30. var_deref_op: Dereference null pointer out2. Signed-off-by: songweibin <song.weibin@zte.com.cn>
CID 180671 (ceph#1 of 1): Dereference null return value (NULL_RETURNS) Signed-off-by: songweibin <song.weibin@zte.com.cn>
CID 172143 (ceph#15 of 15): Branch past initialization (PW.BRANCH_PAST_INITIALIZATION) 1. branch_past_initialization: 2. name_at_decl_position: variable "oid" (declared at line 220) 3. name_at_decl_position: variable "exkeys" (declared at line 241) 4. name_at_decl_position: variable "exvals" (declared at line 242) 5. name_at_decl_position: variable "safe" (declared at line 278) Signed-off-by: songweibin <song.weibin@zte.com.cn>
… the string fix klocwork issues: Width is not specified for 's' conversion specifier. This can result in an overflow of the buffer provided in argument 3 of a call to 'sscanf' Signed-off-by: songweibin <song.weibin@zte.com.cn>
Songweibin
force-pushed
the
wip-fix-cov-kw
branch
from
b61dabe
to
5e8c412
Compare
|
@tchaikov Updated, please take a look, thank you. |
tchaikov
approved these changes
Jul 26, 2019
liewegas
added a commit
that referenced
this pull request
Jul 27, 2019
* refs/pull/29316/head: common,tools: make sure the destination buffer can handle the size of the string src/tools: initialize variables before the goto statement src/mount: check before dereference buf src/crush: check before dereference out2 src/test: s/strcpy/strncpy Reviewed-by: Neha Ojha <nojha@redhat.com> Reviewed-by: Kefu Chai <kchai@redhat.com>
runsisi
pushed a commit
to runsisi/ceph
that referenced
this pull request
Aug 5, 2019
pick from ceph#29316 Change-Id: Ia0c42515d57fdc96cf1be376868b3c544113849f Signed-off-by: songweibin <song.weibin@zte.com.cn>
runsisi
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
Oct 22, 2019
pick from ceph/ceph#29316 Change-Id: Ia0c42515d57fdc96cf1be376868b3c544113849f Signed-off-by: songweibin <song.weibin@zte.com.cn>
xiexingguo
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
Nov 26, 2019
pick from ceph/ceph#29316 Change-Id: Ia0c42515d57fdc96cf1be376868b3c544113849f Signed-off-by: songweibin <song.weibin@zte.com.cn>
Yan-waller
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
May 6, 2020
pick from ceph/ceph#29316 Change-Id: Ia0c42515d57fdc96cf1be376868b3c544113849f Signed-off-by: songweibin <song.weibin@zte.com.cn>
xiexingguo
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
Jul 4, 2020
pick from ceph/ceph#29316 Change-Id: Ia0c42515d57fdc96cf1be376868b3c544113849f Signed-off-by: songweibin <song.weibin@zte.com.cn>
xiexingguo
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
Jul 10, 2020
pick from ceph/ceph#29316 Change-Id: Ia0c42515d57fdc96cf1be376868b3c544113849f Signed-off-by: songweibin <song.weibin@zte.com.cn>
Songweibin
added a commit
to ceph/ceph-ci
that referenced
this pull request
Nov 28, 2020
pick from ceph/ceph#29316 Change-Id: Ia0c42515d57fdc96cf1be376868b3c544113849f Signed-off-by: songweibin <song.weibin@zte.com.cn>
Songweibin
added a commit
to ceph/ceph-ci
that referenced
this pull request
Apr 22, 2021
pick from ceph/ceph#29316 Change-Id: Ia0c42515d57fdc96cf1be376868b3c544113849f Signed-off-by: songweibin <song.weibin@zte.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.