qa/tasks/mgr/test_progress.py: fix bug in 9b4dbf0 #29385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdurgin
approved these changes
Jul 29, 2019
http://pulpito.ceph.com/kchai-2019-07-30_05:20:11-rados-master-distro-basic-smithi/4164376/ |
jdurgin
approved these changes
Jul 30, 2019
|
@kamoltat needs rebase |
kamoltat
force-pushed
the
wip-qa-tasks-mgr-test-progress-bug-fix
branch
from
ec49d7e
to
e89895a
Compare
|
Hi all sorry I made a mistake on git :( |
kamoltat
force-pushed
the
wip-qa-tasks-mgr-test-progress-bug-fix
branch
3 times, most recently
from
cd7e9eb
to
b8f65c7
Compare
follow-up-fix for 9b4dbf0 basically we wanna look at the list that has inprogress events to inprogress+complete Fixes: http://pulpito.ceph.com/kchai-2019-07-28_14:30:09-rados-wip-kefu2-testing-2019-07-28-1941-distro-basic-mira/4160881/ Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
Think the problem is how we are using dictionary.item() in for loop causing runtime error therefore the event didn't get created so we convert it to list(dictionary). Fixes http://pulpito.ceph.com/kchai-2019-07-28_14:30:09-rados-wip-kefu2-testing-2019-07-28-1941-distro-basic-mira/4160881/ Also the same fix as: ceph#28840 Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
kamoltat
force-pushed
the
wip-qa-tasks-mgr-test-progress-bug-fix
branch
from
3cdf26f
to
1322f90
Compare
kamoltat
added a commit
to kamoltat/ceph
that referenced
this pull request
Aug 13, 2019
fix syntax error: events/_events fix issue: https://tracker.ceph.com/issues/40618?next_issue_id=40616&prev_issue_id=40619#note-7 Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
kamoltat
added a commit
to kamoltat/ceph
that referenced
this pull request
Aug 14, 2019
fix syntax error: events/_events fix issue: https://tracker.ceph.com/issues/40618?next_issue_id=40616&prev_issue_id=40619#note-7 Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up-fix for 9b4dbf0
basically we wanna look at the list that has inprogress events and not the list that has inprogress+complete events
Fixes: http://pulpito.ceph.com/kchai-2019-07-28_14:30:09-rados-wip-kefu2-testing-2019-07-28-1941-distro-basic-mira/4160881/
Signed-off-by: Kamoltat (Junior) Sirivadhna ksirivad@redhat.com