Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip 10114 giant #2963

Merged
2 commits merged into from Nov 19, 2014
Merged

Wip 10114 giant #2963

2 commits merged into from Nov 19, 2014

Conversation

dmick
Copy link
Member

@dmick dmick commented Nov 18, 2014

backport from master. Cherry-picked original and fixup commit for clarity.

See discussion in http://tracker.ceph.com/issues/10114

Building with these changes allows output from readelf like this:

 $ readelf -lW src/.libs/librados.so.2 | grep GNU_STACK
  GNU_STACK      0x000000 0x0000000000000000 0x0000000000000000 0x000000
0x000000 RW  0x8

(note the absence of 'X' in 'RW')

Fixes: #10114
Signed-off-by: Dan Mick <dan.mick@redhat.com>
(cherry picked from commit 06a245a)
06a245a added a section def to assembly files; I added it twice to
this file.  There's no damage, but a compiler warning (on machines with
yasm installed)

Signed-off-by: Dan Mick <dan.mick@redhat.com>
(cherry picked from commit 10f6ef1)
@dmick dmick assigned ghost Nov 18, 2014
@ghost ghost added bug-fix core labels Nov 19, 2014
@ghost ghost added this to the giant milestone Nov 19, 2014
ghost pushed a commit that referenced this pull request Nov 19, 2014
Wip 10114 giant

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost merged commit b13a56a into giant Nov 19, 2014
@liewegas liewegas deleted the wip-10114-giant branch November 24, 2014 15:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant