mgr/dashboard: Unify Tasks and Notifications into a sidebar

[tspmelo]

Fixes: https://tracker.ceph.com/issues/37402

Signed-off-by: Tiago Melo tmelo@suse.com

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test docs
• jenkins render docs

[tspmelo]

[tspmelo]

I wrote some questions in the issue.

[votdev]

The commit message has a typo: s/Taks/Task/

[LenzGr]

Nit: there's a small typo in the commit message: s/Taks/Tasks/

[tspmelo]

jenkins retest this please

[tspmelo]

jenkins retest this please

[tspmelo]

jenkins test make check

[callithea]

Tested it locally, I only see processing long running tasks, the notifications e.g. about an updated pool are not displayed in the sidebar.. not sure if someone can reproduce this?

[tspmelo]

@callithea Do you mean the notification that a pool is updating or that it finished updating?

[callithea]

@callithea Do you mean the notification that a pool is updating or that it finished updating?

@tspmelo I can only see that it's updating a pool when the update is still ongoing. But when the update is done I can't see any notifications that I upated the pool. Also I can't see something like you posted in the screenshot about "Created pool xy" when I created a pool.

[tspmelo]

Just tested the PR and got this:

Are you getting any errors in the browser console?

[callithea]

Small update: I can see notifications for e.g. OSDs, but still don't see any when creating/editing pools/RBDs, need to investigate..
I can also see the pop up messages for all actions when it comes to creating/editing/deleting items. But they do not appear in the sidebar notifcation list (except for OSD notifications).

[tspmelo]

jenkins test dashboard

[p-se]

Small update: I can see notifications for e.g. OSDs, but still don't see any when creating/editing pools/RBDs, need to investigate..

I can reproduce that issue. I see popup notifications when creating and deleting an OSD, but don't see any information about that in the sidebar.

Is that on purpose?

I can also see the pop up messages for all actions when it comes to creating/editing/deleting items. But they do not appear in the sidebar notifcation list (except for OSD notifications).

[screenshot removed]

[ricardoasmarques]

+1 for Duration: xxx seconds.

[LenzGr]

the duration is not how long ago it finished, it's how long it took to finish the task.
So the timestamp and duration are showing 2 different information.

That was exactly my point ;) - but you're also putting a duration after the time stamp, that should either be improved by adding the string "ago" behind it, to make clear that these are two different time intervals.

The point I would like to clarify: do we need to print both the time stamp and the time elapsed since that time stamp, or is providing one of them enough?

We could either do a):

[Notification text]
Duration: [duration]
[Time stamp] ([time elapsed] ago)

or b):

[Notification text]
Duration: [duration]
[Time stamp]

or c):

[Notification text]
Duration: [duration]
([time elapsed] ago)

[tspmelo]

Current implementation:

the title overlay is darker, but for some reason, when I try to take a screenshot it fades...

[tspmelo]

It seems the e2e tests are losing the authentication, which doesn't happen when testing manually.
Will have to investigate.

[callithea]

jenkins test dashboard

[callithea]

jenkins test docs

[callithea]

Is it on purpose that the closing button ("X") in the top right corner is surrounded by a light blue box?

In Firefox it's surrounded by grey dots:

This happens when opening the sidebar.

[tspmelo]

@callithea Not on purpose.
Browsers seem to auto focus the button each time the sidebar is opened.
I will try to disable it.

[callithea]

@callithea Not on purpose.
Browsers seem to auto focus the button each time the sidebar is opened.
I will try to disable it.

Re-tested it locally, it's disabled now.

[votdev]

Suggested change

	<ng-container i18n>Duration:</ng-container> {{notification.duration | duration}}
	<ng-container i18n>Duration:</ng-container> {{ notification.duration | duration }}

[votdev]

A new notification shows a few seconds ago though the timestamp (using the browser dev tools) shows that the notification appears 5 minutes ago. The text changes after a page reload to 5 minutes ago. I used Chromium for testing. To me it looks like the notification sidebar is not re-rendered to display the correct time that has passed.

[tspmelo]

@votdev Fixed.

[tspmelo]

jenkins retest this please