New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nautilus: build/ops: use gcc-8 #30089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems devtools-8 is not packaged on aarch64. and we are suffering from ICE on centos7 when building with GCC-7.3. so let's try GCC-8.2! Fixes: http://tracker.ceph.com/issues/38892 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 5ae3b06)
should activate devtoolset-8 not devtoolset-7 for enabling GCC-8. Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 9694a72)
to be consistent with ceph#27183 and ceph/ceph-build#1286 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit f52d69e)
@tchaikov Cool, thanks! I'm not going to hit the merge button, yet, though - waiting for |
test this please |
jenkins test docs |
@tchaikov in the description did you actually mean to say "let's move to GCC-8" rather than "let's move to GCC-7"? |
cbodley
approved these changes
Sep 13, 2019
badone
approved these changes
Sep 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we are using DTS-7 on CentOS7 and gcc-7 from ubuntu-toolchain-r PPA on xenial already for building nautilus.
we switched to GCC-8 in master for addressing ICE issues. these issues may or may not impact nautilus. and it's found that some builders are using GCC-8. even though
install-deps.sh
only installs gcc-7 if the installed GCC is lower than 7 on xenial. also, it's found that if we compile nautilus tree using GCC-7. we haveso, to ensure that we use the same compiler for building nautilus. let's move to GCC-8. also as a side-effect, the produced binary should be better because of the newer (and better) library, compiler and toolchain.