Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimic: osd/PeeringState: do not complain about past_intervals constrained by oldest epoch #30222

Merged
merged 1 commit into from Oct 3, 2019
Merged

mimic: osd/PeeringState: do not complain about past_intervals constrained by oldest epoch #30222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/osd/PG.cc
View file
Open in desktop
Expand Up @@ -896,11 +896,15 @@ bool PG::needs_backfill() const

void PG::check_past_interval_bounds() const
{
auto oldest_epoch = osd->get_superblock().oldest_map;
auto rpib = get_required_past_interval_bounds(
info,
osd->get_superblock().oldest_map);
oldest_epoch);
if (rpib.first >= rpib.second) {
if (!past_intervals.empty()) {
// do not warn if the start bound is dictated by oldest_map; the
// past intervals are presumably appropriate given the pg info.
if (!past_intervals.empty() &&
rpib.first > oldest_epoch) {
osd->clog->error() << info.pgid << " required past_interval bounds are"
<< " empty [" << rpib << ") but past_intervals is not: "
<< past_intervals;
Expand Down