Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crimson/osd: extend OpsExecuter to carry about op effects. #30310

Merged
merged 1 commit into from Sep 11, 2019

Conversation

rzarzynski
Copy link
Contributor

This commit brings a new infrastructural piece that will be needed by e.g. the watch/notify mechanism.

Signed-off-by: Radoslaw Zarzynski rzarzyns@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs

This commit brings a new infrastructural piece that will be
needed by e.g. the watch/notify mechanism.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. could you run it through the CBT test?

@rzarzynski
Copy link
Contributor Author

$ /work/cbt/compare.py -a /tmp/baseline -b /tmp/wip-crimson-op_effects/ -v
06:58:15 - DEBUG    - cbt      - Nodes : ubulap
06:58:15 - DEBUG    - cbt      - Nodes : ubulap
06:58:15 - DEBUG    - cbt      - Nodes : ubulap
06:58:15 - INFO     - cbt      - prefill/ubulap/0: latency_avg: (or (less) (near 0.05)):: 0.00544142/0.00628144  => accepted
06:58:15 - INFO     - cbt      - prefill/ubulap/0: bandwidth: (or (greater) (near 0.05)):: 11.4737/9.94873  => accepted
06:58:15 - INFO     - cbt      - prefill/ubulap/0: iops_avg: (or (greater) (near 0.05)):: 2937.0/2546.0  => accepted
06:58:15 - INFO     - cbt      - prefill/ubulap/0: iops_stddev: (or (less) (near 0.05)):: 53.9846/223.583  => accepted
06:58:15 - INFO     - cbt      - prefill/ubulap/1: latency_avg: (or (less) (near 0.05)):: 0.00536614/0.00631721  => accepted
06:58:15 - INFO     - cbt      - prefill/ubulap/1: bandwidth: (or (greater) (near 0.05)):: 11.6253/9.88365  => accepted
06:58:15 - INFO     - cbt      - prefill/ubulap/1: iops_avg: (or (greater) (near 0.05)):: 2976.0/2530.0  => accepted
06:58:15 - INFO     - cbt      - prefill/ubulap/1: iops_stddev: (or (less) (near 0.05)):: 41.5251/251.448  => accepted
06:58:15 - INFO     - cbt      - seq/ubulap/0: latency_avg: (or (less) (near 0.05)):: 0.000946638/0.000992531  => accepted
06:58:15 - INFO     - cbt      - seq/ubulap/0: bandwidth: (or (greater) (near 0.05)):: 64.0495/60.8442  => accepted
06:58:15 - INFO     - cbt      - seq/ubulap/0: iops_avg: (or (greater) (near 0.05)):: 16396.0/15576.0  => accepted
06:58:15 - INFO     - cbt      - seq/ubulap/0: iops_stddev: (or (less) (near 0.05)):: 0.0/0.0  => accepted
06:58:15 - INFO     - cbt      - seq/ubulap/1: latency_avg: (or (less) (near 0.05)):: 0.000893563/0.000999561  => accepted
06:58:15 - INFO     - cbt      - seq/ubulap/1: bandwidth: (or (greater) (near 0.05)):: 69.0809/61.8109  => accepted
06:58:15 - INFO     - cbt      - seq/ubulap/1: iops_avg: (or (greater) (near 0.05)):: 17684.0/15823.0  => accepted
06:58:15 - INFO     - cbt      - seq/ubulap/1: iops_stddev: (or (less) (near 0.05)):: 0.0/0.0  => accepted
06:58:15 - INFO     - cbt      - All 16 tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
2 participants