Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: REST API: OpenAPI docs require internet connection #30477

Merged
merged 1 commit into from Sep 26, 2019
Merged

mgr/dashboard: REST API: OpenAPI docs require internet connection #30477

merged 1 commit into from Sep 26, 2019

Conversation

p-se
Copy link
Contributor

@p-se p-se commented Sep 19, 2019 •
edited

Adds the swagger-ui-dist package to package.json and loads resources locally instead from the internet.

Fixes: https://tracker.ceph.com/issues/40027

Signed-off-by: Patrick Seidensal pseidensal@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs

@p-se p-se requested a review from tspmelo September 19, 2019 13:29
@p-se p-se requested a review from a team as a code owner September 19, 2019 13:29
@bk201
Copy link
Contributor

bk201 commented Sep 20, 2019

jenkins test docs

@p-se p-se force-pushed the wip-pna-swagger-offline-deps branch from ff24ce5 to 23e6771 Compare September 20, 2019 06:40
@p-se p-se requested a review from LenzGr September 20, 2019 06:42
votdev
votdev approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@votdev votdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p-se p-se force-pushed the wip-pna-swagger-offline-deps branch from 23e6771 to 3f2a8e4 Compare September 20, 2019 10:56
epuertat
epuertat approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@tspmelo
Copy link
Contributor

tspmelo commented Sep 20, 2019

jenkins test make check

@tchaikov
Copy link
Contributor

retest this please.

@p-se
Copy link
Contributor Author

p-se commented Sep 23, 2019

jenkins test make check

@p-se
Copy link
Contributor Author

p-se commented Sep 23, 2019

jenkins test make check arm64

1 similar comment
@p-se
Copy link
Contributor Author

p-se commented Sep 24, 2019

jenkins test make check arm64

@LenzGr LenzGr merged commit f742283 into ceph:master Sep 26, 2019
@shyukri shyukri mentioned this pull request Feb 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tspmelo tspmelo tspmelo approved these changes

@votdev votdev votdev approved these changes

@epuertat epuertat epuertat approved these changes

@LenzGr LenzGr Awaiting requested review from LenzGr

Assignees
No one assigned
Labels
bug-fix dashboard needs-review wip-kefu-testing
Projects
None yet
Milestone
No milestone
7 participants
@p-se @bk201 @tspmelo @tchaikov @votdev @epuertat @LenzGr