Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: skip add empty multipart chain to gc in abort_multipart_upload #30511

Merged
merged 1 commit into from
May 8, 2020

Conversation

tianshan
Copy link
Contributor

Fixes: https://tracker.ceph.com/issues/41953

Signed-off-by: Tianshan Qu tianshan@xsky.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs

@tchaikov
Copy link
Contributor

Error: 

      72 |     });
      73 | 
    > 74 |     it('current active status of tabs should not change when selection is same with previour selection', () => {
         |     ^
      75 |       fixture.detectChanges();
      76 |       const tabs = poolDetailsComponent.tabsetChild.tabs;
      77 |       expect(tabs[0].active).toBeTruthy();

https://tracker.ceph.com/issues/41814

retest this please.

@tchaikov tchaikov added the rgw label Sep 23, 2019
Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@cbodley
Copy link
Contributor

cbodley commented Oct 24, 2019

@tianshan could you please rebase?

@cbodley
Copy link
Contributor

cbodley commented Dec 19, 2019

@tianshan ping, please rebase

@tianshan
Copy link
Contributor Author

@cbodley sorry for late reply, rebase done.

@stale
Copy link

stale bot commented Mar 30, 2020

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Mar 30, 2020
@ivancich ivancich added the wip-eric-testing-1 for ivancich testing label May 6, 2020
@stale stale bot removed the stale label May 6, 2020
@ivancich
Copy link
Member

ivancich commented May 8, 2020

@ivancich ivancich merged commit 6cde82b into ceph:master May 8, 2020
@ivancich ivancich removed needs-qa wip-eric-testing-1 for ivancich testing labels May 8, 2020
@ivancich
Copy link
Member

ivancich commented May 8, 2020

@tianshan You did not list any backports on the tracker. So I marked it as "Resolved". If it needs backports please update the tracker and change the status to "Pending backport".

@mattbenjamin , @cbodley including you both in in case you have an opinion here.

@mattbenjamin
Copy link
Contributor

@ivancich octopus and nautilus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants