WIP-8797: fix python thread hanging bug #3053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sys.exit does not guarantee garbage collection in threads, possibly preventing Rados.shutdown() from being called causing python to hang due to http://bugs.python.org/issue21963 . Signed-off-by: Joe Julian <me@joejulian.name>
ghost
assigned 
|
I assert that this does not depend on the two commits referenced above, and can serve as a useful hardening against these Python versions that have this behavior (and Python3 probably does as well). |
|
Note that 0.87 is also affected by this bug. The proposed patch applies cleanly to the 0.87 source tree, and fixes the hang-on-exit for Arch Linux's Ceph 0.87 package. Agreed with @dmick that this patch doesn't depend on the SIGILL fix, though both sets should be backported to 0.87. |
|
See #3119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys.exit does not guarantee garbage collection in threads, possibly
preventing Rados.shutdown() from being called causing python to hang due
to http://bugs.python.org/issue21963 .
Signed-off-by: Joe Julian me@joejulian.name