mimic: msg/async: do not trigger RESETSESSION from connect fault during connection phase #30672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
added
the
messenger
|
Luminous is perilously close to crossing over the line into EOL land, if it has not crossed it already. But mimic is still alive and well. |
liewegas
approved these changes
Oct 1, 2019
smithfarm
force-pushed
the
wip-37520-mimic
branch
3 times, most recently
from
fa39d92
to
65b6864
Compare
…ection phase Previously, if we got a connection fault during the connect/connect_reply phase, we would increment connect_seq on the client side and trigger a RESETSESSION on the server side (because there was not yet an existing connection to replace). This led to dropped messages, usually in the form of stuck peering in the rados/thrash suite. The problem is that the condition for 'reconnect' vs 'backoff' inherited the test from SimpleMessenger, which had only a STATE_CONNECTING. In contract, AsyncMessenger also as CONNECTING_WAIT_BANNER_AND_IDENTIFY and CONNECTING_SEND_CONNECT_MSG, and if we were in these states, we would increment connect_seq instead of backing off and retrying (without an increment). Fix by adjusting the condition to match the range of CONNECTING states in asyncmessenger. Fixes: http://tracker.ceph.com/issues/36612 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 8346e39) Conflicts: src/msg/async/Protocol.cc - file does not exist in mimic: applied changes manually in src/msg/async/AsyncConnection.cc - mimic uses different states and does not have "connection" abstraction - mimic needs to pass "async_msgr->cct" to ldout instead of just cct
smithfarm
force-pushed
the
wip-37520-mimic
branch
from
65b6864
to
00b1635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/37520
backport of #25343
parent tracker: https://tracker.ceph.com/issues/36612
this backport was staged using https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh