ceph-volume: revert --no-tmpfs change #30788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0092c5b. Signed-off-by: Sage Weil <sage@redhat.com>
|
@guits what's the secret incantation to make jenkins test ceph-volume? |
|
jenkins test ceph-volume |
|
jenkins test ceph-volume tox |
13 tasks
|
@liewegas could be nice to explain why we have to revert in the commit message |
This reverts commit e6c578a. It turns out this change isn't actually needed to make ceph-daemon do its thing, since ceph-volume alrady skips doing anything with tmpfs if the data dir already exists. Signed-off-by: Sage Weil <sage@redhat.com>
|
yep, updated!
|
guits
approved these changes
Oct 8, 2019
jan--f
approved these changes
Oct 8, 2019
liewegas
added a commit
that referenced
this pull request
Oct 8, 2019
* refs/pull/30788/head: Revert "ceph-volume: accept --no-tmpfs argument for bluestore" Revert "ceph-volume: no_tmpfs -> tmpfs" Reviewed-by: Jan Fajerski <jfajerski@suse.com> Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke things, but more importantly it didn't end up being necessary: c-v seems to skip the tmpfs part if the data directory already exists, so ceph-daemon works as intended without any changes.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docs