Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: use small default pg count for CephFS pools #30816

Merged
merged 2 commits into from Oct 15, 2019
Merged

Conversation

batrick
Copy link
Member

@batrick batrick commented Oct 9, 2019

The pg count needs to be a power-of-two since
dff5697.

Also, mon_pg_warn_min_per_osd is disabled by default now (or set to a
low value in vstart/testing) so there's no need to base the pg count on
this value.

Fixes: https://tracker.ceph.com/issues/42228
Signed-off-by: Patrick Donnelly pdonnell@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs

@batrick batrick requested review from liewegas and a team October 9, 2019 17:45
@batrick batrick force-pushed the i42228 branch 2 times, most recently from ae47d7c to 24cb368 Compare October 9, 2019 18:08
@batrick
Copy link
Member Author

batrick commented Oct 9, 2019

ceph/teuthology#1322

Follows: 609ab5a
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Copy link
Member

@callithea callithea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The pg count needs to be a power-of-two since
dff5697.

Also, mon_pg_warn_min_per_osd is disabled by default now (or set to a
low value in vstart/testing) so there's no need to base the pg count on
this value.

Ideally someday we can remove this so that the default cluster value is
used but we need to keep this for deployments of older versions of Ceph.

Fixes: https://tracker.ceph.com/issues/42228
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
batrick added a commit to batrick/ceph that referenced this pull request Oct 14, 2019
* refs/pull/30816/head:
	qa: use small default pg count for CephFS pools
	*: remove config of "mon pg warn min per osd" in testing

Reviewed-by: Laura Paduano <lpaduano@suse.com>
batrick added a commit that referenced this pull request Oct 15, 2019
* refs/pull/30816/head:
	qa: use small default pg count for CephFS pools
	*: remove config of "mon pg warn min per osd" in testing

Reviewed-by: Laura Paduano <lpaduano@suse.com>
@batrick batrick merged commit fc88e6c into ceph:master Oct 15, 2019
@batrick batrick deleted the i42228 branch October 15, 2019 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants