python-rados: Add object lock support #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
SUCCESS make check |
|
Could you please add a Signed-off-by to the commit message ? And while you're at it could you also include http://tracker.ceph.com/issues/6114 Refs: #6114 in the commit comment to show progress in the relevant context ? |
|
Running the test manually as explained at http://dachary.org/?p=3216 succeeds: $ LD_LIBRARY_PATH=.libs PYTHONPATH=pybind nosetests -v test/pybind/test_rados.py:TestIoctx.test_lock test_rados.TestIoctx.test_lock ... ok ---------------------------------------------------------------------- Ran 1 test in 3.186s OK |
|
Little things related to the commit message, otherwise great work ! |
This change adds to the python binding the support of: - rados_lock_exclusive - rados_lock_shared - rados_unlock http://tracker.ceph.com/issues/6114 Refs: ceph#6114 Signed-off-by: Mehdi Abaakouk <sileht@redhat.com>
sileht
force-pushed
the
sileht/python-rados-object-lock
branch
from
48170e3
to
f5bf75f
Compare
|
I have made the modification in the commit message, thank for reviewing. |
ghost
pushed a commit
that referenced
this pull request
Dec 6, 2014
python-rados: Add object lock support Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi,
This changes adds to the python binding the support of:
Cheers,