python-common: Add mypy testing #31071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for mypy usage |
sebastian-philipp
force-pushed
the
python-common-mypy
branch
from
e643e11
to
0243f90
Compare
|
This has an impact on make check, but its not related to QA. |
|
jenkins test make check arm64 |
tchaikov
reviewed
Oct 25, 2019
| pytest | ||
| commands=py.test -v {posargs:ceph/tests} | ||
| deps=-rrequirements.txt | ||
| commands=python setup.py test --addopts="--mypy --mypy-ignore-missing-imports" {posargs} |
There was a problem hiding this comment.
There is a special overrride for [testenv:py27] below. I.e. there is no way to run this test for Python 2
There was a problem hiding this comment.
i still don't get it. i think it's
[testenv:py27]
commands=python setup.py test {posargs}
which overrides the global setting.
so "py3" will be using
python setup.py test --addopts="--mypy --mypy-ignore-missing-imports" {posargs}
for testing. as "lint" has its own "commands" already.
There was a problem hiding this comment.
So you would prefer to have a [testenv:py3] here? I can do that!
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
sebastian-philipp
force-pushed
the
python-common-mypy
branch
from
0243f90
to
9ba33ac
Compare
This was referenced Oct 25, 2019
jan--f
approved these changes
Oct 28, 2019
bk201
reviewed
Oct 28, 2019
Comment on lines
+6
to
+11
| if sys.version_info >= (3,0): | ||
| mypy = ['mypy', 'pytest-mypy'] | ||
| pytest = 'pytest >=2.1.3' | ||
| else: | ||
| mypy = [] | ||
| pytest = 'pytest >=2.1.3,<5' |
There was a problem hiding this comment.
Just for a record.
https://docs.pytest.org/en/latest/py27-py34-deprecation.html
3 tasks
|
Probably caused https://tracker.ceph.com/issues/42528 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
cc @jschmid1
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docs