nautilus: mgr/dashboard: Add transifex-i18ntool #31160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2019 12:38
Adds the npm package transifex-i18ntool which manages the translation files of the ceph dashboard Backporting the transifex-i18ntool is an important step to synchronize the nautilus translations with transifex more or less automatically. The npm scripts still need to be started manual, but merging the xlf files etc. will be handled by the i18ntool. Signed-off-by: Sebastian Krah <skrah@suse.com> (cherry picked from commit d33b5d3) Conflicts: src/pybind/mgr/dashboard/frontend/package-lock.json - Had to be updated since the devDependencies in the package.json changed src/pybind/mgr/dashboard/frontend/package.json - Added the transifex-i18ntool as dependency and some scripts to automate the i18n workflow src/pybind/mgr/dashboard/run-frontend-unittests.sh - The way how to extract source language file changed the and had to be adapted New file: src/pybind/mgr/dashboard/frontend/i18n.config.json - Stores the settings for the transifex-i18ntool
Since the settings will divide from master the resource must be updated. The i18ntool should use the correct resource for the nautilus branch and not the same as master or any other version. Otherwise we would miss translations. Signed-off-by: Sebastian Krah <skrah@suse.com>
|
jenkins test dashboard |
6 similar comments
|
jenkins test dashboard |
|
jenkins test dashboard |
|
jenkins test dashboard |
|
jenkins test dashboard |
|
jenkins test dashboard |
|
jenkins test dashboard |
|
jenkins test dashboard |
1 similar comment
|
jenkins test dashboard |
|
QA run [1 failed / 3 passed]: New round of QA was successful: |
callithea
approved these changes
Nov 19, 2019
callithea
added
ready-to-merge
and removed
nautilus-batch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/42482