Bug fix about MOSDOp print ops trigger buffer::list::ptr assert failure #3117
Conversation
ghost
added
|
Don't you think the copy operation also has a chance to run into problems ? It seems to me that the caller should be modified to get a proper lock and ensure that it is not printing a data structure that is being modified. Also could you please add a Signed-off-by: at the end of the commit message ? You can check the git log to see how it is done. The tracker number should also be included like so: http://tracker.ceph.com/issues/9916 Fixes: #9916 |
|
It seems like the bigger problem here is that the reference is being changed. Where do you see that? If that's what we're doing we want to be very careful (and explciit) about it |
|
I am sorry, after tried my best, I haven't found an explicit change on the op reference. |
|
You could make ops private, and add a get_ops() method that returns a const ref. The compiler will throw errors for all of the users and switching them to get_ops() will identify whcih ones, if any, are non-const.. |
We don't exactly do continuous builds on all the platforms marked with "B", but we have published binary RPMs for them. Adjust the "B" footnote definition to reflect this. Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
Similar to the change in commit 4cdc9c7, remove the references to old Ceph releases. Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
Fedora doesn't have point releases, so it doesn't make sense to talk about "Fedora 18.0" or "Fedora 19.0" - it's just "Fedora 18" or "Fedora 19". Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
Added ceph.target Made ceph-mds, ceph-mon, ceph-osd services part of ceph.target Made ceph-mds, ceph-mon, ceph-osd services require partitions to be available. Added ceph init script with sysV like behaviour. Provided by Tim Serong tserong@suse.com and Owen Synge osynge@suse.com Signed-off-by: Owen Synge <osynge@suse.com>
|
SUCCESS: make check http://paste.ubuntu.com/9437494/ |
Sent from 
|
Sorry that the pull request has messed up for my incorrect operation, I will take more analysis and test of this bug, and make another pull request. |
This should fix the bug: http://tracker.ceph.com/issues/9916 Fixes: #9916