Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librbd: features converting bitmask and string API #31188

Merged
merged 3 commits into from Nov 8, 2019
Merged

librbd: features converting bitmask and string API #31188

merged 3 commits into from Nov 8, 2019

Conversation

zhengchengyao
Copy link
Contributor

Signed-off-by: Zheng Yin zhengyin@cmss.chinamobile.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs

@zhengchengyao
Copy link
Contributor Author

retest this please.

@zhengchengyao zhengchengyao force-pushed the rbd_features branch 2 times, most recently from a0f6af3 to 7191c63 Compare October 28, 2019 13:08
dillaman
dillaman reviewed Oct 29, 2019
View reviewed changes
src/include/rbd/librbd.h Outdated Show resolved Hide resolved
src/include/rbd/librbd.h Outdated Show resolved Hide resolved
src/librbd/librbd.cc Outdated Show resolved Hide resolved
src/librbd/librbd.cc Outdated Show resolved Hide resolved
src/pybind/rbd/rbd.pyx Outdated Show resolved Hide resolved
src/include/rbd/librbd.h Outdated Show resolved Hide resolved
src/include/rbd/librbd.hpp Outdated Show resolved Hide resolved
@dillaman
Copy link

dillaman commented Oct 29, 2019 •
edited

... also, please use the librbd: prefix in your commit message instead of rbd: features converting bitmask and string API

@zhengchengyao zhengchengyao changed the title rbd: features converting bitmask and string API librbd: features converting bitmask and string API Oct 30, 2019
@zhengchengyao
Copy link
Contributor Author

zhengchengyao commented Oct 30, 2019 •
edited

Hi dillaman，thanks for your good advice， I have changed it, thans a lot.

dillaman
dillaman reviewed Oct 30, 2019
View reviewed changes
src/librbd/librbd.cc Outdated Show resolved Hide resolved
src/include/rbd/librbd.h Outdated Show resolved Hide resolved
dillaman
dillaman reviewed Oct 31, 2019
View reviewed changes
src/include/rbd/librbd.h Outdated Show resolved Hide resolved
src/include/rbd/librbd.hpp Outdated Show resolved Hide resolved
src/librbd/librbd.cc Outdated Show resolved Hide resolved
@zhengchengyao zhengchengyao force-pushed the rbd_features branch 2 times, most recently from 384b538 to 4d79eb3 Compare October 31, 2019 15:21
dillaman
dillaman reviewed Oct 31, 2019
View reviewed changes
src/librbd/librbd.cc Outdated Show resolved Hide resolved
@zhengchengyao
test/librbd: add features_to_string and features_from_string test case
4ecc8ec 
Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>
@zhengchengyao
Copy link
Contributor Author

jenkins test make check

dillaman
dillaman reviewed Nov 1, 2019
View reviewed changes
src/librbd/librbd.cc Outdated Show resolved Hide resolved
src/librbd/librbd.cc Outdated Show resolved Hide resolved
src/librbd/librbd.cc Outdated Show resolved Hide resolved
src/librbd/librbd.cc Outdated Show resolved Hide resolved
dillaman
dillaman reviewed Nov 1, 2019
View reviewed changes
src/librbd/librbd.cc Outdated Show resolved Hide resolved
dillaman
dillaman approved these changes Nov 1, 2019
View reviewed changes
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhengchengyao
Copy link
Contributor Author

jenkins test make check

1 similar comment
@zhengchengyao
Copy link
Contributor Author

jenkins test make check

@dillaman
Copy link

dillaman commented Nov 6, 2019

Fails python tests: http://qa-proxy.ceph.com/teuthology/jdillaman-2019-11-06_13:09:11-rbd-wip-jd-testing-distro-basic-smithi/4477036/teuthology.log

@zhengchengyao
Copy link
Contributor Author

sorry，last time I forgot to test in the local environment.
I have tested it in the local environment，thanks.

test_rbd.TestTrash.test_remove ... ok
test_rbd.TestTrash.test_remove_denied ... ok
test_rbd.TestTrash.test_remove_with_progress ... ok
test_rbd.TestTrash.test_restore ... ok
test_rbd.test_features_from_string ... ok
test_rbd.test_features_to_string ... ok
test_rbd.test_open_by_id ... ok
test_rbd.test_pool_stats ... ok

[ OK ] TestLibRBD.MetadataPP (0 ms)
[ RUN ] TestLibRBD.UpdateFeatures
SKIPPING
[ OK ] TestLibRBD.UpdateFeatures (0 ms)
[ RUN ] TestLibRBD.FeaturesBitmaskString
[ OK ] TestLibRBD.FeaturesBitmaskString (0 ms)
[ RUN ] TestLibRBD.RebuildObjectMap
using old format
[ OK ] TestLibRBD.RebuildObjectMap (74 ms)
[ RUN ] TestLibRBD.RebuildNewObjectMap

@zhengchengyao
librbd: features converting bitmask and string API
c12e032 
Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>
@zhengchengyao
test/pybind: add features test case
b8ae468 
add features_to_string and features_from_string test case

Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>
@zhengchengyao
Copy link
Contributor Author

jenkins test make check arm64

@dillaman dillaman merged commit 97db947 into ceph:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillaman dillaman dillaman approved these changes

Assignees
No one assigned
Labels
feature rbd
Projects
None yet
Milestone
No milestone
3 participants
@zhengchengyao @dillaman @batrick