nautilus: core: auth/Crypto: fallback to /dev/urandom if getentropy() fails #31301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we still support Linux 3.10, which does not support `getrandom(2)`. so even if the glibc installed on the building host offers `getentropy()` call, we still need to check for the syscall's existence at runtime in case that the Linux kernel version is lower than 3.17 which introduced the support of `getrandom(2)`. in this chance, we detect the existence of `getentropy()` by using it when constructing `CryptoRandom`, this system call could fail due to 3 reasons: 1. ENOSYS: the kernel does not support `getrandom(2)` 2. EPERM: the syscall is blocked by a security policy 3. EINTR: interrupted by a signal so we fall back to /dev/urandom in cases of ENOSYS and EPERM, retry on EINTR, otherwise, an exception is thrown. Fixes: https://tracker.ceph.com/issues/42018 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit bb6d9c3)
this assert() will be optimized out in Release mode. Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit ccae47e)
smithfarm
changed the title
|
test this please |
jdurgin
approved these changes
Dec 18, 2019
|
@yuriw @smithfarm please note that the parent PR is tagged as rgw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/42134
backport of #30544
parent tracker: https://tracker.ceph.com/issues/42018
this backport was staged using ceph-backport.sh version 15.0.0.6612
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh