Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: Incorrectly calling ceph::buffer::list::decode_base64 in bucket policy #31356

Merged
merged 1 commit into from Jan 22, 2020
Merged

rgw: Incorrectly calling ceph::buffer::list::decode_base64 in bucket policy #31356

merged 1 commit into from Jan 22, 2020

Conversation

xxcs
Copy link

@xxcs xxcs commented Nov 4, 2019 •
edited by adamemerson

rgw: Incorrectly calling ceph::buffer::list::decode_base64 in bucket policy

Fixes: https://tracker.ceph.com/issues/42616
Signed-off-by: GaryHyg huygbj@inspur.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@cbodley
Copy link
Contributor

cbodley commented Nov 4, 2019

@adamemerson where's the right place to add a test case that covers this?

adamemerson
adamemerson approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@adamemerson adamemerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leopards Gobble Tahrs Messily.

@adamemerson
Copy link
Contributor

@bodley test_rgw_iam_policy.cc, maybe just a call to the now-fixed function.

@stale
Copy link

stale bot commented Jan 5, 2020

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jan 5, 2020
@GaryHyg
Copy link
Contributor

GaryHyg commented Jan 6, 2020

just for removing the stale label.

@stale stale bot removed the stale label Jan 6, 2020
@cbodley cbodley merged commit 3d00484 into ceph:master Jan 22, 2020
@cbodley
Copy link
Contributor

cbodley commented Jan 22, 2020

http://pulpito.ceph.com/cbodley-2020-01-21_20:23:35-rgw-wip-cbodley-testing-distro-basic-smithi/

@smithfarm smithfarm mentioned this pull request Jan 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamemerson adamemerson adamemerson approved these changes

Assignees
No one assigned
Labels
bug-fix needs-qa rgw wip-cbodley-testing
Projects
None yet
Milestone
No milestone
4 participants
@xxcs @cbodley @adamemerson @GaryHyg