WorkQueue.cc: Limit the lock granularity #3136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinze Chi <xmdxcxz@gmail.com>
|
the purpose of the _process_finish hook is that it happens under the lock. if there is a particular workqueue user that doesn't need that, it should move it's code from _process_finish to _process. I'm guessing your concerned with the FileStore::_finish_op()? |
|
Yes, I agree with you that move FileStore::_finish_op to FileStore::_do_op is better. |
|
I believe the code in finish_op() is dependent on being run under the lock. If anything is moved into do_op it needs to be done very carefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xinze Chi xmdxcxz@gmail.com