Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Display the aggregated number of request #31369

Merged
merged 1 commit into from Dec 2, 2019
Merged

mgr/dashboard: Display the aggregated number of request #31369

merged 1 commit into from Dec 2, 2019

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Nov 4, 2019

convertTimeSeries will now calculate the aggregated total number of client
request made in the last seconds, instead of the number of request per second.

Fixes: https://tracker.ceph.com/issues/42622

Signed-off-by: Tiago Melo tmelo@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

mgr/dashboard: Display the aggregated number of request
1dc483e 
convertTimeSeries will now calculate the aggregated total number of client
request made in the last seconds, instead of the number of request per second.

Fixes: https://tracker.ceph.com/issues/42622

Signed-off-by: Tiago Melo <tmelo@suse.com>
@tspmelo tspmelo requested a review from Devp00l November 4, 2019 16:31
@tspmelo tspmelo requested a review from a team as a code owner November 4, 2019 16:31
@tspmelo
Copy link
Contributor Author

tspmelo commented Nov 11, 2019

jenkins test dashboard

Devp00l
Devp00l approved these changes Nov 22, 2019
View reviewed changes
Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, looks a lot better now :) 👍

@tspmelo tspmelo requested a review from a team November 25, 2019 11:19
ricardoasmarques
ricardoasmarques approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LenzGr LenzGr merged commit 02a2ba8 into ceph:master Dec 2, 2019
@tspmelo tspmelo deleted the wip-deltaTimeSeries branch December 2, 2019 12:41
@shyukri shyukri mentioned this pull request May 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoasmarques ricardoasmarques ricardoasmarques approved these changes

@Devp00l Devp00l Devp00l approved these changes

Assignees
No one assigned
Labels
dashboard
Projects
None yet
Milestone
No milestone
4 participants
@tspmelo @ricardoasmarques @Devp00l @LenzGr