install-deps.sh: Install python headers on openSUSE/SLE #31434
Conversation
When installing python modules from source, the python headers are
needed when the module needs to compile code. This is eg. needed for
xmlsec. Without Python.h available, ./install-deps.sh fails with:
/tmp/pip-wheel-Kx6zVj/xmlsec/src/platform.h:16:10: \
fatal error: Python.h: No such file or directory
Fixes: https://tracker.ceph.com/issues/42665
Signed-off-by: Thomas Bechtold <tbechtold@suse.com>
toabctl
force-pushed
the
install-python-headers
branch
from
6fdd774
to
1d5e2ac
Compare
|
master is supposed to be going all-out Python 3. Why is At the very least, we should be careful not to introduce Python 2 onto a system that doesn't already have it... |
I just tried to call |
|
@toabctl Python 2 EOL is coming very soon and Octopus (planned release March 2020) will not support it. See, e.g.:
So, in master (the future Octopus), we can already act as if Python 2 is not supported. |
|
Nautilus supports CentOS 7, which is similar to openSUSE 42.* - i.e. a py2 distro. So, for nautilus we have to keep the py2 stuff around. But assuming the plan doesn't change, Octopus will not support any py2 distros. |
|
i think the problem Thomas ran into is that we are stilling building/installing wheels for python2.7 in install-deps.sh even if the distro already moved to python3. in this case, openSUSE Tumbleweed uses python3.7. probably a better fix is to drop python2 tox tests in "make check" . see #31525 |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
| @@ -414,6 +414,8 @@ else | |||
| echo "Using zypper to install dependencies" | |||
| zypp_install="zypper --gpg-auto-import-keys --non-interactive install --no-recommends" | |||
| $SUDO $zypp_install systemd-rpm-macros | |||
| # python header files are needed to install inside the virtualenv (eg. xmlsec needs the header files) | |||
| $SUDO $zypp_install python-devel python3-devel | |||
There was a problem hiding this comment.
i think we already install python%{python3_pkgversion}-devel, so presumably, python3-devel should be installed by
$SUDO $zypp_install $(rpmspec -q --buildrequires $DIR/ceph.spec)and since we dropped python2 support in master, we don't need to install python-devel anymore.
When installing python modules from source, the python headers are
needed when the module needs to compile code. This is eg. needed for
xmlsec. Without Python.h available, ./install-deps.sh fails with:
/tmp/pip-wheel-Kx6zVj/xmlsec/src/platform.h:16:10:
fatal error: Python.h: No such file or directory
Fixes: https://tracker.ceph.com/issues/42665
Signed-off-by: Thomas Bechtold tbechtold@suse.com