mgr/ssh: add make check integration

[sebastian-philipp]

Extracted from #30262

Might be able to drop the cmake integration, if we #30364 is in.

Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com

Depends on:

• mgr/orchestrator_cli: remove tox and move test to parent dir #31561

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard backend
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[toabctl]

Couldn't we patch the module where the tests are executed? Mixing the mocking code and the real code in one file doesn't look very nice imo.

[sebastian-philipp]

We have that problem that we can't import .module as some base classes are generated in C++ and thus will fail with a NameError. Do you have a better idea?

[toabctl]

hm. no.

[sebastian-philipp]

See #31561

[sebastian-philipp]

@tchaikov what do you think. would it be ok to just add remoto as a dependency in the mgr's ../requirements.txt in order to simplify testing this module? We have to have the dependency for make check anyway.

[liewegas]

ImportError while importing test module '/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/ssh/tests/test_ssh.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
__init__.py:14: in <module>
    from mock import Mock, MagicMock
E   ImportError: No module named mock
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!

[sebastian-philipp]

ImportError while importing test module '/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/ssh/tests/test_ssh.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
__init__.py:14: in <module>
    from mock import Mock, MagicMock
E   ImportError: No module named mock
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!

Fixed in https://github.com/ceph/ceph/pull/31561/files#diff-5f73b53794fdc79745e3723b3947f73cR2