cmake: link ceph-fuse against librt #31531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceph-fuse: fix error of building ceph-fuse fix linking error of without -lrt for ceph-fuse. error message: ``` [100%] Building CXX object src/CMakeFiles/ceph-fuse.dir/ceph_fuse.cc.o [100%] Building CXX object src/CMakeFiles/ceph-fuse.dir/client/fuse_ll.cc.o [100%] Linking CXX executable ../bin/ceph-fuse /opt/rh/devtoolset-7/root/usr/libexec/gcc/x86_64-redhat-linux/7/ld: CMakeFiles/ceph-fuse.dir/ceph_fuse.cc.o: undefined reference to symbol 'clock_gettime@@GLIBC_2.2.5' //lib64/librt.so.1: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status make[3]: *** [bin/ceph-fuse] Error 1 make[2]: *** [src/CMakeFiles/ceph-fuse.dir/all] Error 2 make[1]: *** [src/CMakeFiles/ceph-fuse.dir/rule] Error 2 make: *** [ceph-fuse] Error 2 ``` Signed-off-by: Yong Wang <wy7980@sina.com>
tchaikov
reviewed
Nov 11, 2019
tchaikov
reviewed
Nov 11, 2019
wy7980
changed the title
Yes, the new title can be more clear. |
|
@wy7980 could you squash these two commits into a single one? |
|
@wy7980 instead of creating a new PR for addressing the reviewers' comments, i'd recommend reusing the existing one. you can always use |
|
@wy7980 also, would be great if you could use your full name in your "Signed-off-by" line. i don't think it's "wy7980", otherwise it's just very unusual.. |
wy7980
force-pushed
the
patch-4
branch
2 times, most recently
from
fede9ab
to
aabfe40
Compare
got it. |
tchaikov
approved these changes
Nov 13, 2019
batrick
added a commit
that referenced
this pull request
Nov 20, 2019
* refs/pull/31531/head: cmake: link ceph-fuse against librt Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ceph-fuse: fix error of building ceph-fuse
fix linking error of without -lrt for ceph-fuse.
error message:
Signed-off-by: Yong Wang wy7980@sina.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox