backport-resolve-issue: narrow regular expression and read key/token from files #31594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tspmelo
suggested changes
Nov 18, 2019
The regular expression used to extract tracker URLs from the PR body was too generous. When there are two URLs on the same line and the second is a tracker URl, the regex picked up both of them. For example, the following string matched the regex: "ceph#26538, https://tracker.ceph.com/issues/41452" This commit fixes the issue. Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm
force-pushed
the
wip-bri-regex-fix
branch
2 times, most recently
from
415f98a
to
c4854d2
Compare
Thanks to Tiago Melo for inspiring me to do this. Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm
force-pushed
the
wip-bri-regex-fix
branch
from
c4854d2
to
7dc1bd2
Compare
|
@tspmelo Please take another look. It should be ready now. |
smithfarm
changed the title
tspmelo
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression used to extract tracker URLs from the PR body
was too generous. When there were two URLs on the same line and the
second was a tracker URL, the regex picked up both of them. For example,
the following string matched the regex:
https://github.com/ceph/ceph/pull/26538, https://tracker.ceph.com/issues/41452This commit fixes the issue.
Signed-off-by: Nathan Cutler ncutler@suse.com