Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nautilus: mgr/volumes: allow setting uid, gid of subvolume and subvolume group during creation #31741

Merged
merged 6 commits into from Jan 18, 2020
Merged

nautilus: mgr/volumes: allow setting uid, gid of subvolume and subvolume group during creation #31741

merged 6 commits into from Jan 18, 2020

Conversation

joscollin
Copy link
Member

@joscollin joscollin commented Nov 19, 2019 •
edited by ajarr

@joscollin
mgr/volumes: uid, gid for subvolume create and subvolumegroup create …
ee853e2 
…commands

Allow setting uid, gid for subvolume create and subvolumegroup create commands

Fixes: https://tracker.ceph.com/issues/40959
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 63226a7)
@joscollin
cephfs: chown function
1bb0fbb 
Fixes: https://tracker.ceph.com/issues/40959
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 4ad4158)
@joscollin
qa/tasks: uid, gid for subvolume create and subvolumegroup create com…
c60c9b4 
…mands

Fixes: https://tracker.ceph.com/issues/40959
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit a1ff179)
@joscollin joscollin added this to the nautilus milestone Nov 19, 2019
@joscollin joscollin added cephfs Ceph File System feature labels Nov 19, 2019
@smithfarm
Copy link
Contributor

@joscollin Would you be willing to help me test ceph-backport.sh? Each time I manage to convince someone to try it, some improvement of the script comes out of it.

@joscollin
Copy link
Member Author

@joscollin Would you be willing to help me test ceph-backport.sh? Each time I manage to convince someone to try it, some improvement of the script comes out of it.

I've not tried any of those scripts, except the ptl-tool. What does it do?

@joscollin
Copy link
Member Author

jenkins test make check

@vshankar
Copy link
Contributor

@joscollin -- might want to include #31756

@smithfarm
Copy link
Contributor

smithfarm commented Nov 22, 2019 •
edited

@joscollin The ceph-backport.sh script is described here:

https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst#opening-a-backport-pr

The tl;dr is:

  1. grab src/script/ceph-backport.sh from tip of master, put it somewhere in your PATH
  2. run ceph-backport.sh BACKPORT_TRACKER_ID (for example, if the backport tracker is https://tracker.ceph.com/issues/55555 then you run ceph-backport.sh 55555

The first time you run it the script will ask some questions - it needs your GitHub token and Redmine API key to do its work.

vshankar and others added 2 commits December 9, 2019 20:29
@vshankar @joscollin
pybind / cephfs: remove static typing in LibCephFS.chown
0055fbd 
The routine does type checking anyway, plus, to be uniform
with other APIs.

Fixes: http://tracker.ceph.com/issues/42923
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit bbbfb44)
@joscollin
mgr/volumes: check for string values in uid/gid
67d7221 
chown allows strings as per bbbfb44,
which caused this error. Eventhough uid/gid are input as CephInt, the
qa tests can pass in only string values to _fs_cmd. So try converting
the incoming uid/gid to int in create_subvolume and create_group.
It might be a valid string.

Fixes: https://tracker.ceph.com/issues/43038
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 4c1029b)
@joscollin
Copy link
Member Author

@joscollin -- might want to include #31756

Fixed

@joscollin
Copy link
Member Author

@batrick @smithfarm The backport work is completed. Please review.

@smithfarm smithfarm added the nautilus-batch-1 nautilus point releases label Dec 12, 2019
@joscollin
doc: uid, gid for subvolume create and subvolumegroup create commands
e31e7a0 
Fixes: https://tracker.ceph.com/issues/40959
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 596c1fe)
@yuriw
Copy link
Contributor

yuriw commented Jan 9, 2020

wip-yuri6-testing-2020-01-09-1744-nautilus

@tchaikov
Copy link
Contributor

jenkins test make check

@yuriw
Copy link
Contributor

yuriw commented Jan 17, 2020

retest this please

1 similar comment
@yuriw
Copy link
Contributor

yuriw commented Jan 17, 2020

retest this please

@yuriw yuriw merged commit 9254996 into ceph:nautilus Jan 18, 2020
@joscollin joscollin deleted the wip-42886-nautilus branch January 18, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajarr ajarr ajarr approved these changes

@batrick batrick Awaiting requested review from batrick

@smithfarm smithfarm Awaiting requested review from smithfarm

Assignees
No one assigned
Labels
cephfs Ceph File System feature nautilus-batch-1 nautilus point releases needs-qa wip-yuri6-testing
Projects
None yet
Milestone
nautilus
7 participants
@joscollin @smithfarm @vshankar @yuriw @tchaikov @ajarr @batrick