mgr/volumes: improve volume deletion process #31762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscollin
approved these changes
Nov 20, 2019
tserong
approved these changes
Nov 21, 2019
|
@jschmid1 Do a QA run and check |
Could you forward me to a doc on how to do that? |
|
@jschmid1 please create a Ceph tracker ticket so that we don't forget to backport it to nautilus, and have the commit mention that it |
jschmid1
force-pushed
the
fix_mds_removal_ssh
branch
from
89c3878
to
80e239d
Compare
added 2 commits
November 21, 2019 16:55
Instead of checking if the --yes-i-really-mean-it flag was set _after_ removing the MDS daemon, we need to check if before starting any removal operation. Fixes: https://tracker.ceph.com/issues/42931 Signed-off-by: Joshua Schmid <jschmid@suse.de>
Fixes: https://tracker.ceph.com/issues/42931 Signed-off-by: Joshua Schmid <jschmid@suse.de>
jschmid1
force-pushed
the
fix_mds_removal_ssh
branch
from
80e239d
to
8b461cf
Compare
@joscollin Please schedule the run yourself. |
batrick
approved these changes
Nov 21, 2019
|
batrick
added a commit
that referenced
this pull request
Nov 26, 2019
* refs/pull/31762/head: mgr/ssh: improve logging for mds removal mgr/volumes: move up 'confirm' validation Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Tim Serong <tserong@suse.com> Reviewed-by: Jos Collin <jcollin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking if the --yes-i-really-mean-it
flag was set after removing the MDS daemon, we
need to check if before starting any removal operation.
Signed-off-by: Joshua Schmid jschmid@suse.de