Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: rgw: Fixed bug on wrong name for user_id for OPA #31972

Merged
merged 1 commit into from Dec 4, 2019

Conversation

clwluvw
Copy link
Contributor

@clwluvw clwluvw commented Dec 3, 2019

No description provided.

@theanalyst theanalyst changed the title [Documentation]: [Fixed bug on wrong name for user_id] doc: rgw: Fixed bug on wrong name for user_id for OPA Dec 3, 2019
@theanalyst
Copy link
Member

missing a signed-off-by, and while at it, it'd be great if you could amend the commit title like the PR title https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#sign-your-work
This can be done by amending the commit and then force-pushing

@clwluvw clwluvw force-pushed the patch-1 branch 3 times, most recently from f030b9a to 58523c1 Compare December 3, 2019 13:22
@clwluvw
Copy link
Contributor Author

clwluvw commented Dec 3, 2019

Done

@clwluvw
Copy link
Contributor Author

clwluvw commented Dec 3, 2019

I don't have any idea why tests failed when docs edited 😕

@cbodley cbodley added the rgw label Dec 3, 2019
@cbodley
Copy link
Contributor

cbodley commented Dec 3, 2019

the test failures are from SSHOrchestrator and should be fixed in #31969. can you try rebasing over the current master branch?

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
@clwluvw
Copy link
Contributor Author

clwluvw commented Dec 3, 2019

I have rebased it with master but still tests fails!

@cbodley
Copy link
Contributor

cbodley commented Dec 3, 2019

jenkins test make check

@clwluvw
Copy link
Contributor Author

clwluvw commented Dec 4, 2019

Tests passed ✔️

@cbodley cbodley merged commit 18555ad into ceph:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants