common/config: update values when they are removed via mon #32091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a value is set via the mon (ceph config set ...), and then later removed, the removal doesn't propagate to the legacy values (or debug options) because update_legacy_values() only iterates over legacy value and not debug options. Similarly, we want to trigger a config notification to any observers, so we need to add the option to values.changed. Fixes: https://tracker.ceph.com/issues/42964 Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
added
bug-fix
core
wip-sage-testing
needs-review
and removed
wip-sage-testing
labels
neha-ojha
approved these changes
Dec 11, 2019
liewegas
added a commit
that referenced
this pull request
Dec 11, 2019
* refs/pull/32091/head: common/config: update values when they are removed via mon Reviewed-by: Neha Ojha <nojha@redhat.com>
|
@liewegas is this a dup? https://tracker.ceph.com/issues/43296 |
|
nope, that's a different bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a value is set via the mon (ceph config set ...), and then later
removed, the removal doesn't propagate to the legacy values (or debug
options) because update_legacy_values() only iterates over legacy value
and not debug options.
Similarly, we want to trigger a config notification to any observers,
so we need to add the option to values.changed.
Fixes: https://tracker.ceph.com/issues/42964
Signed-off-by: Sage Weil sage@redhat.com