qa: Enable flake8 tox and fix failures #32129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toabctl
changed the title
kshtsk
reviewed
Dec 9, 2019
kshtsk
reviewed
Dec 9, 2019
kshtsk
reviewed
Dec 9, 2019
kshtsk
reviewed
Dec 9, 2019
kshtsk
reviewed
Dec 9, 2019
kshtsk
reviewed
Dec 9, 2019
kshtsk
reviewed
Dec 9, 2019
kshtsk
reviewed
Dec 9, 2019
kshtsk
reviewed
Dec 9, 2019
kshtsk
reviewed
Dec 9, 2019
toabctl
force-pushed
the
qa-enable-flake8
branch
2 times, most recently
from
cb9db41
to
96e848f
Compare
kshtsk
reviewed
Dec 10, 2019
kshtsk
reviewed
Dec 10, 2019
toabctl
force-pushed
the
qa-enable-flake8
branch
from
96e848f
to
9a80428
Compare
|
jenkins test make check |
toabctl
force-pushed
the
qa-enable-flake8
branch
2 times, most recently
from
4440670
to
9cb1bd6
Compare
|
I dropped the python3 flake8 run commit for now (there are problems with the venvs). |
toabctl
changed the title
toabctl
force-pushed
the
qa-enable-flake8
branch
from
9cb1bd6
to
9d566bd
Compare
|
@liewegas imo ready for merging now. |
tchaikov
reviewed
Dec 11, 2019
toabctl
force-pushed
the
qa-enable-flake8
branch
from
9d566bd
to
c7e2714
Compare
|
I guess we need an exhaustive QA run for this PR? |
tchaikov
approved these changes
Dec 11, 2019
There were a couple of problems found by flake8 in the qa/ directory (most of them fixed now). Enabling flake8 during the usual check runs hopefully avoids adding new issues in the future. Signed-off-by: Thomas Bechtold <tbechtold@suse.com>
toabctl
force-pushed
the
qa-enable-flake8
branch
from
c7e2714
to
0127cd1
Compare
|
rebased... |
kshtsk
reviewed
Dec 12, 2019
| @@ -360,7 +358,7 @@ class TestStandbyReplay(CephFSTestCase): | |||
|
|
|||
| def _confirm_no_replay(self): | |||
| status = self.fs.status() | |||
| standby_count = len(list(status.get_standbys())) | |||
| _ = len(list(status.get_standbys())) | |||
There was a problem hiding this comment.
Why not just remove this line if it is not used?
liewegas
added a commit
that referenced
this pull request
Dec 12, 2019
* refs/pull/32129/head: qa: Enable flake8 tox and fix failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of problems found by flake8 in the qa/
directory (most of them fixed now). Enabling flake8 during the usual
check runs hopefully avoids adding new issues in the future.
Signed-off-by: Thomas Bechtold tbechtold@suse.com