list objects with specific snapshot #3213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix ceph#9738 Signed-off-by: xinxin shu <xinxin.shu@intel.com>
ghost
added
|
@liewegas , can you review this patch? |
|
@liewegas ， do you have time to review this? |
|
It's not clear what this series is attempting to do. Before you reopen, please create a document in doc/dev/osd_internals as part of the patch series explaining what you are trying to do, why, and how. On a related note, any attempt to interpret an osd level structure (like SnapSet) below the ObjectStore interface is probably not going to be acceptable. You'd need to replumb the interface to allow that to work without violating the abstractions, and we'd need a very good reason to do a significant change to the ObjectStore interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9738
Signed-off-by: xinxin shu xinxin.shu@intel.com