client: disallow changing fuse_default_permissions option at runtime #32315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
david-z
force-pushed
the
wip-fix-fuse_default_permissions
branch
2 times, most recently
from
d3a64dd
to
77fa7bc
Compare
|
jenkins test make check |
|
@batrick pls review this PR some time, thanks. |
batrick
requested changes
Jan 6, 2020
david-z
force-pushed
the
wip-fix-fuse_default_permissions
branch
from
77fa7bc
to
ab072c0
Compare
|
jenkins test make check |
batrick
requested changes
Jan 8, 2020
If fuse_default_permissions is false when initializing fuse, then ceph-fuse will use its own permission check. If changig this option to true at runtime, there will be no permission check at both fuse side and ceph-fuse side. Fixes: https://tracker.ceph.com/issues/43362 Signed-off-by: Zhi Zhang <zhangz.david@outlook.com>
david-z
force-pushed
the
wip-fix-fuse_default_permissions
branch
from
ab072c0
to
dea4ffe
Compare
batrick
approved these changes
Jan 10, 2020
jtlayton
approved these changes
Jan 13, 2020
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Jan 15, 2020
* refs/pull/32315/head: client: disallow changing fuse_default_permissions option at runtime Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
batrick
added a commit
that referenced
this pull request
Jan 15, 2020
* refs/pull/32315/head: client: disallow changing fuse_default_permissions option at runtime Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Jeff Layton <jlayton@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If fuse_default_permissions is false when initializing fuse, then ceph-fuse
will use its own permission check. If changing this option to true at
runtime, there will be no permission check at both fuse side and
ceph-fuse side.
Fixes: https://tracker.ceph.com/issues/43362
Signed-off-by: Zhi Zhang zhangz.david@outlook.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox