qa: krbd_exclusive_option.sh: fixup for json.tool ordering change #32358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idryomov
force-pushed
the
wip-krbd-py3-fixup
branch
from
a46bc63
to
b2b7610
Compare
In Python 3.5 json.tool was changed to produce unsorted output and --sort-keys option was added to compensate. This wasn't caught by 4fe245c ("qa: update krbd tests for python3") because it raced with 50933b8 ("qa: krbd_exclusive_option.sh: update for recent kernel changes"). Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
|
jenkins test make check |
1 similar comment
|
jenkins test make check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.5 json.tool was changed to produce unsorted output and
--sort-keys option was added to compensate. This wasn't caught by
4fe245c ("qa: update krbd tests for python3") because it raced
with 50933b8 ("qa: krbd_exclusive_option.sh: update for recent
kernel changes").
Signed-off-by: Ilya Dryomov idryomov@gmail.com