Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librbd: diff iterate with fast-diff now correctly includes parent #32403

Merged
merged 1 commit into from Dec 25, 2019
Merged

librbd: diff iterate with fast-diff now correctly includes parent #32403

merged 1 commit into from Dec 25, 2019

Conversation

dillaman
Copy link

When whole-object and include-parent options are enabled, the
diff will now include the parent image diffs. Previously, the
parent image diffs were not included when fast-diff was enabled
but was included when fast-diff was disabled.

Fixes: https://tracker.ceph.com/issues/42248
Signed-off-by: Jason Dillaman dillaman@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

librbd: diff iterate with fast-diff now correctly includes parent
b61f83b 
When whole-object and include-parent options are enabled, the
diff will now include the parent image diffs. Previously, the
parent image diffs were not included when fast-diff was enabled
but was included when fast-diff was disabled.

Fixes: https://tracker.ceph.com/issues/42248
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
trociny
trociny approved these changes Dec 24, 2019
View reviewed changes
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trociny
Copy link
Contributor

trociny commented Dec 25, 2019

@ceph-jenkins retest this please

@trociny trociny merged commit 8b84cdf into ceph:master Dec 25, 2019
@dillaman dillaman deleted the wip-42248 branch December 25, 2019 15:24
This was referenced Jan 3, 2020
Merged
Merged
Closed
@smithfarm smithfarm mentioned this pull request Feb 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trociny trociny trociny approved these changes

Assignees
No one assigned
Labels
bug-fix needs-qa rbd wip-mgolub-testing
Projects
None yet
Milestone
No milestone
2 participants
@dillaman @trociny