osd/PG: clean up fastinfo key when last_update does not increase #32615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
fix-43580
branch
2 times, most recently
from
29aa690
to
1de6111
Compare
tchaikov
reviewed
Jan 13, 2020
|
i just skimmed thru the related code in luminous,mimic, and nautilus, and found they also suffer from the same issue. so i added backport =luminous,mimic,nautilus in https://tracker.ceph.com/issues/43580. please correct me if i am wrong. |
tchaikov
requested changes
Jan 13, 2020
There was a problem hiding this comment.
build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/huge/release/15.0.0-9259-gdc6e437/rpm/el8/BUILD/ceph-15.0.0-9259-gdc6e437/src/test/objectstore/ObjectStoreTransactionBenchmark.cc: In member function 'uint64_t PerfCase::rados_write_4k(int)':
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/huge/release/15.0.0-9259-gdc6e437/rpm/el8/BUILD/ceph-15.0.0-9259-gdc6e437/src/test/objectstore/ObjectStoreTransactionBenchmark.cc:216:11: error: 'class Transaction' has no member named 'omap_rmkey'; did you mean 'omap_rmkeys'?
t.omap_rmkey(meta_cid, pglog_oid, pglog_attr);
^~~~~~~~~~
omap_rmkeys
|
retest this please |
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
less cluttered this way Signed-off-by: Kefu Chai <kchai@redhat.com>
If the last_update field goes backwards, we write a full info instead of the fastinfo key. However, a stale fastinfo key may still be present, and it may have a last_update that looks valid to a restarting OSD. Fixes: https://tracker.ceph.com/issues/43580 Reported-by: song <jinglesong0814@163.com> Signed-off-by: Sage Weil <sage@redhat.com>
|
@liewegas the original changeset broke the crimson build. see https://shaman.ceph.com/builds/ceph/wip-kefu-testing-2020-01-14-1029/c56ab079cfbe534c1e4cb5371924dc825539e79d/crimson/183535/ . so i fixed it and pushed to your branch. |
tchaikov
approved these changes
Jan 14, 2020
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the last_update field goes backwards, we write a full info instead of
the fastinfo key. However, a stale fastinfo key may still be present, and
it may have a last_update that looks valid to a restarting OSD.
Fixes: https://tracker.ceph.com/issues/43580
Signed-off-by: Sage Weil sage@redhat.com