Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Clone an existing user role #32653

Merged
merged 1 commit into from Jan 22, 2020
Merged

mgr/dashboard: Clone an existing user role #32653

merged 1 commit into from Jan 22, 2020

Conversation

votdev
Copy link
Member

@votdev votdev commented Jan 15, 2020 •
edited

Peek 2020-01-15 15-24

Fixes: https://tracker.ceph.com/issues/43603

Signed-off-by: Volker Theile vtheile@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@votdev votdev requested a review from a team as a code owner January 15, 2020 14:26
@callithea
Copy link
Member

jenkins test dashboard

@callithea
Copy link
Member

callithea commented Jan 16, 2020 •
edited

Will re-trigger the pkg build.

Latest QA run [6/6 passed]: http://pulpito.ceph.com/laura-2020-01-20_16:46:18-rados:dashboard-wip-laura-testing-32650-32652-distro-basic-smithi/

@votdev
Copy link
Member Author

votdev commented Jan 20, 2020

jenkins test make check arm64

callithea
callithea approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@callithea callithea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, lgtm

@votdev
Copy link
Member Author

votdev commented Jan 21, 2020

jenkins test make check arm64

@votdev votdev requested a review from a team January 21, 2020 11:41
tspmelo
tspmelo suggested changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@tspmelo tspmelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have some kind of feedback, probably a notification, informing me that the operation is running or has finished.

If you have 2 pages of roles and clone a role from the 1st page with a name that will put it in the 2nd page, you have no idea if anything happened.

@votdev
mgr/dashboard: Clone an existing user role
944490f 
Fixes: https://tracker.ceph.com/issues/43603

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev
Copy link
Member Author

votdev commented Jan 21, 2020

Would be nice to have some kind of feedback, probably a notification, informing me that the operation is running or has finished.

If you have 2 pages of roles and clone a role from the 1st page with a name that will put it in the 2nd page, you have no idea if anything happened.

Good idea. A notification will be displayed now.

tspmelo
tspmelo approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@tspmelo tspmelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@callithea
Copy link
Member

Latest QA run passed: http://pulpito.ceph.com/laura-2020-01-22_12:14:03-rados:dashboard-wip-laura-testing-32648-32653-distro-basic-smithi/

@callithea callithea merged commit c60b9cf into ceph:master Jan 22, 2020
@votdev votdev deleted the issue_43603_clone_role branch January 22, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tspmelo tspmelo tspmelo approved these changes

@callithea callithea callithea approved these changes

Assignees
No one assigned
Labels
dashboard feature
Projects
None yet
Milestone
No milestone
3 participants
@votdev @callithea @tspmelo