Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nautilus: ceph-volume: add raw (--bluestore) mode #32733

Merged
merged 6 commits into from Jan 22, 2020
Merged

nautilus: ceph-volume: add raw (--bluestore) mode #32733

merged 6 commits into from Jan 22, 2020

Conversation

leseb
Copy link
Member

@leseb leseb commented Jan 20, 2020

Checklist

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@liewegas @leseb
ceph-volume: show devices with bluestore labels and unavailable
b5cde81 
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 4b81bc8)
@liewegas @leseb
ceph-volume: add raw mode
658d20a 
list, prepare, activate, create (prepare+activate) basic bluestore OSDs
on a single device.

No support (or plans to ever support) dmcrypt.

I think support for db/wal could be added later without much trouble.

For now, we require --no-systemd and --bluestore flags because we haven't
implemented support for anything else but suspect we will in the future,
and would like to ensure users are being explicit about what they're
asking for.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 1e9de77)
@liewegas @leseb
raw: --osd-fsid throughout
a450bcd 
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 4e7e694)
@liewegas @leseb
raw: fix activate args
a9275d1 
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 5e9d917)
@liewegas @leseb
ceph-volume: raw: activate: drop --all, --osd-id and --osd-fsid args
1186ae1 
We don't need these currently.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit e7b8b5c)
@leseb leseb added this to the nautilus milestone Jan 20, 2020
@leseb leseb requested a review from jan--f January 20, 2020 13:01
@jan--f
Copy link
Contributor

jan--f commented Jan 20, 2020

Probably ideal to wait for #32655 and backport this as well in one go.

@leseb
Copy link
Member Author

leseb commented Jan 20, 2020

Probably ideal to wait for #32655 and backport this as well in one go.

Thanks!

@leseb
Copy link
Member Author

leseb commented Jan 20, 2020

Probably ideal to wait for #32655 and backport this as well in one go.

Thanks!

I'll do a bulk backport then.

@leseb
ceph-volume: fix device unittest, mock has_bluestore_label, lint
f3dca3b 
This also adds a test case for has_bluestore_label.

Fixes: https://tracker.ceph.com/issues/43611

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
(cherry picked from commit 91c7f51)
@leseb
Copy link
Member Author

leseb commented Jan 21, 2020

@jan--f updated with f3dca3b. PTAL

@jan--f
Copy link
Contributor

jan--f commented Jan 22, 2020

jenkins test ceph-volume tox

@leseb
Copy link
Member Author

leseb commented Jan 22, 2020

@jan--f CI is green :-)

@jan--f
Copy link
Contributor

jan--f commented Jan 22, 2020

This part at least :)

@jan--f jan--f merged commit 70f5f0d into ceph:nautilus Jan 22, 2020
@leseb leseb deleted the cv-raw-bp branch January 23, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f jan--f approved these changes

Assignees
No one assigned
Labels
ceph-volume feature
Projects
None yet
Milestone
nautilus
3 participants
@leseb @jan--f @liewegas