Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: modify iam tests to use a function to set bits #32808

Merged
merged 1 commit into from Jan 29, 2020
Merged

test: modify iam tests to use a function to set bits #32808

merged 1 commit into from Jan 29, 2020

Conversation

theanalyst
Copy link
Member

This reduces the need for the tests to also always modify the binary string for every new addition in the bitfields

Signed-off-by: Abhishek Lekshmanan abhishek@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@theanalyst
test: modify iam tests to use another iterator function to set bits
0b3525b 
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
@theanalyst theanalyst changed the title test: modify iam tests to use another iterator function to set bits rgw: test: modify iam tests to use another iterator function to set bits Jan 23, 2020
@theanalyst theanalyst changed the title rgw: test: modify iam tests to use another iterator function to set bits test: modify iam tests to use a function to set bits Jan 23, 2020
@theanalyst theanalyst added the rgw label Jan 23, 2020
adamemerson
adamemerson approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@adamemerson adamemerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this greatly!

@cbodley
Copy link
Contributor

cbodley commented Jan 23, 2020

feel free to merge once make check completes

@theanalyst theanalyst merged commit b92cbad into ceph:master Jan 29, 2020
@theanalyst theanalyst deleted the rgw/test-iam-bits branch January 29, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamemerson adamemerson adamemerson approved these changes

@cbodley cbodley cbodley approved these changes

@pritha-srivastava pritha-srivastava Awaiting requested review from pritha-srivastava

Assignees
No one assigned
Labels
rgw
Projects
None yet
Milestone
No milestone
3 participants
@theanalyst @cbodley @adamemerson