osd: make message cap option usable again #32855
Conversation
|
@yuyuyu101 do you recall more details about the livelock you mentioned in #14944? It seems like the ops throttle would be helpful for small messages (like deletes, or cls calls - one we've seen is related to RGW gc) that are expensive for the OSD. I'm curious if this msg cap can be effective in at least stopping the OSD from becoming overloaded and suiciding in such cases. |
|
retest this please |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
jdurgin
force-pushed
the
wip-message-cap
branch
2 times, most recently
from
56e28d0
to
ac3ec25
Compare
jdurgin
changed the title
This reverts commit 45d5ac3. Without a msg throttler, we can't change osd_client_message_cap cap. The throttler is designed to work with 0 as a max, so change the default to 0 to disable it by default instead. This doesn't affect the default behavior, it only lets us use this option again. Fixes: https://tracker.ceph.com/issues/46143 Conflicts: src/ceph_osd.cc - new style of gconf() access Signed-off-by: Josh Durgin <jdurgin@redhat.com> Signed-off-by: Neha Ojha <nojha@redhat.com>
This reverts commit 45d5ac3.
Without a msg throttler, we can't change osd_client_message_cap cap.
The throttler is designed to work with 0 as a max, so change the
default to 0 to disable it by default instead.
This doesn't affect the default behavior, it only lets us use this
option again.
Fixes: https://tracker.ceph.com/issues/46143
Conflicts:
src/ceph_osd.cc - new style of gconf() access
Signed-off-by: Josh Durgin jdurgin@redhat.com
Signed-off-by: Neha Ojha nojha@redhat.com