nautilus: mgr/telemetry: fix device serial number anonymization #32948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Model names sometimes have underscores in them, hence it is not safe to split the string <vendor>_<model>_<serial> by '_' and expect the correct corresponding tuple. For now we'll take the string after the last '_' as the serial. - Fixed back_ip to be retrieved from cluster_addrs instead of public_addrs. - Omitted the ':' from 'pg_num:' key. This won't break the telemetry server since it does not extract this key, but calculates it from 'pools'. Signed-off-by: Yaarit Hatuka <yaarit@redhat.com> (cherry picked from commit e4d5ece) Conflicts: ceph-mgr in nautilus is still using python2, we should use python2 compatible syntax in this backport commit. See ceph#32926
tchaikov
approved these changes
Jan 29, 2020
|
jenkins test make check |
|
|
jenkins test make check |
neha-ojha
approved these changes
Feb 12, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #32492
Please see: #32926