qa/tasks/ceph: only re-request scrub on unscrubbed pgs #32988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we haven't scrubbed everything, we occasinoally re-request scrub in case the request was missed by the OSD (this can happen). But we were re-requesting scrub on ALL pgs, and if they are done in a semi-deterministic order and are slow, then we may never get to the final ones. Signed-off-by: Sage Weil <sage@redhat.com>
|
i think that's what happened here: http://pulpito.ceph.com/sage-2020-01-29_20:14:58-rados-wip-sage-testing-2020-01-29-1034-distro-basic-smithi/4718248 |
neha-ojha
approved these changes
Jan 30, 2020
liewegas
added a commit
that referenced
this pull request
Jan 31, 2020
* refs/pull/32988/head: qa/tasks/ceph: only re-request scrub on unscrubbed pgs Reviewed-by: Neha Ojha <nojha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we haven't scrubbed everything, we occasinoally re-request scrub in case
the request was missed by the OSD (this can happen). But we were
re-requesting scrub on ALL pgs, and if they are done in a
semi-deterministic order and are slow, then we may never get to the final
ones.
Signed-off-by: Sage Weil sage@redhat.com