common/TextTable,mgr: standardize on 2 spaces between table columns #33138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
liewegas
commented
Feb 8, 2020
liewegas
commented
tchaikov
reviewed
Feb 9, 2020
| * | ||
| * @param s String to separate columns | ||
| */ | ||
| void set_column_separation(const std::string& s) { |
There was a problem hiding this comment.
where is this method used?
| @@ -53,6 +53,7 @@ class TextTable { | |||
| std::vector<TextTableColumn> col; // column definitions | |||
| unsigned int curcol, currow; // col, row being inserted into | |||
| unsigned int indent; // indent width when rendering | |||
| std::string column_separation = {" "}; | |||
There was a problem hiding this comment.
Suggested change
| std::string column_separation = {" "}; | |
| constexpr static std::string_view column_separation = {" "}; |
liewegas
force-pushed
the
wip-table-sep
branch
2 times, most recently
from
7c64882
to
592d692
Compare
sebastian-philipp
approved these changes
Feb 20, 2020
liewegas
force-pushed
the
wip-table-sep
branch
2 times, most recently
from
6bfbebe
to
441a632
Compare
|
retest this please |
liewegas
added
wip-sage4-testing
wip-sage2-testing
and removed
wip-sage3-testing
wip-sage4-testing
labels
This is what other projects and libraries default to, and it is more legible. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-table-sep
branch
from
441a632
to
eadd83d
Compare
|
retest this please |
No need to pad on the right-hand side if there are no additional columns that follow. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-table-sep
branch
from
eadd83d
to
41f0035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.